[Intel-gfx] [PATCH 2/2] x86: add early quirk for reserving Intel graphics stolen memory

Chris Wilson chris at chris-wilson.co.uk
Wed Jul 24 20:22:58 CEST 2013


On Wed, Jul 24, 2013 at 11:09:18AM -0700, Jesse Barnes wrote:
> On Wed, 24 Jul 2013 18:59:02 +0100
> Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > > +	base = read_pci_config_32(num, slot, func, 0x5c);
> > > +	base &= ~((1<<20) - 1);
> > 
> > I wish there was some synatic sugar we can apply for base &= -MB(1);
> 
> I think it's clear enough.  Or is this a snarky comment that kernel.h
> has a macro for this you're not mentioning? :)

I was being sincere! It's an idiom that crops up often enough, so I
wondering aloud if someone had a neat solution.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list