[Intel-gfx] [PATCH 00/13] modeset interface cleanups

Rodrigo Vivi rodrigo.vivi at gmail.com
Fri Jul 26 20:42:57 CEST 2013


Although I had those 2 doubts and aren't 100% sure this wont cause any
regression I'm confortable in give my rv-b to full series.

So,

Reviewed-by: Rodrigo Vivi <rodrigo.vivi at gmail.com>



On Sun, Jul 21, 2013 at 4:36 PM, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> Hi all,
>
> I've figured it's time that we rip out our legacy modeset encoder callbacks from
> the crtc helpers and only use the new ones. This patch series converts over the
> last few stragglers of encoder_helper_funcs->mode_set and ->mode_fixup.
>
> As the icing on the cake I've thrown in a conversion of the old timings_set
> logic to something more natural in our new world where we precompute the entire
> pipe config and can freely control the code flow in that stage.
>
> Comments, flames and testing highly welcome.
>
> Cheers, Daniel
>
> Daniel Vetter (13):
>   drm/i915/dvo: use intel_encoder to the upcast macro
>   drm/i915/dvo: switch ->mode_fixup to ->compute_config
>   drm/i915: rip out legacy encoder->mode_fixup logic
>   drm/i915/dvo: use native encoder ->mode_set callback
>   drm/i915/sdvo: use intel_encoder for upcast helper
>   drm/i915/tv: Use native encoder->mode_set callback
>   drm/i915/crt: use native encoder->mode_set callback
>   drm/i915/hdmi: use native encoder mode_set callback
>   drm/i915/dp: use native encoder ->mode_set callback
>   drm/i915/lvds: use the native encoder ->mode_set callback
>   drm/i915/ddi: use the native encoder ->mode_set callback
>   drm/i915: rip out legacy encoder->mode_set callback
>   drm/i915: clean up crtc timings computation
>
>  drivers/gpu/drm/i915/intel_crt.c     | 34 +++++++++-------------
>  drivers/gpu/drm/i915/intel_ddi.c     | 39 +++++++++++--------------
>  drivers/gpu/drm/i915/intel_display.c | 36 ++++-------------------
>  drivers/gpu/drm/i915/intel_dp.c      | 19 +++++-------
>  drivers/gpu/drm/i915/intel_drv.h     |  4 ---
>  drivers/gpu/drm/i915/intel_dvo.c     | 56 +++++++++++++++++-------------------
>  drivers/gpu/drm/i915/intel_hdmi.c    | 29 ++++++++-----------
>  drivers/gpu/drm/i915/intel_lvds.c    | 16 ++++-------
>  drivers/gpu/drm/i915/intel_panel.c   |  3 --
>  drivers/gpu/drm/i915/intel_sdvo.c    | 23 +++++++--------
>  drivers/gpu/drm/i915/intel_tv.c      | 27 ++++++-----------
>  11 files changed, 105 insertions(+), 181 deletions(-)
>
> --
> 1.8.1.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br



More information about the Intel-gfx mailing list