[Intel-gfx] [PATCH] drm/i915: fix gen4 digital port hotplug definitions

[Daniel Vetter]

On Fri, Jul 26, 2013 at 07:54:22PM +0200, Daniel Vetter wrote:
> On Fri, Jul 26, 2013 at 01:21:48PM +0300, Jani Nikula wrote:
> > On Fri, 26 Jul 2013, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> > > Apparently Bspec is wrong in this case here even for gm45. Note that
> > > Bspec is horribly misguided on i965g/gm, so we don't have any other
> > > data points besides that it seems to make machines work better.
> > >
> > > With this changes all the bits in PORT_HOTPLUG_STAT for the digital
> > > ports are ordered the same way. This seems to agree with what register
> > > dumps from the hpd storm handling code shows, where the LIVE bit and
> > > the short/long pulse STATUS bits light up at the same time with this
> > > enumeration (but no with the one from Bspec).
> > 
> > Would a comment about this near the #defines be in order? To avoid the
> > "these values are all wrong per bspec" patches.
> 
> Yeah, good idea, I'll add a comment when merging this.

Done and merged with your irc-ack.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch