[Intel-gfx] [PATCH] drm/i915: Use the same pte_encoding for ppgtt as for gtt

Ben Widawsky ben at bwidawsk.net
Wed Jul 31 09:42:35 CEST 2013


On Tue, Jul 30, 2013 at 07:04:37PM +0100, Chris Wilson wrote:
> The PTE layouts are the same for both ppgtt and gtt, so we can simplify
> the setup for ppgtt by copying the encoding function pointer from gtt.
> This prevents bugs where we update one function pointer, but forget the
> other.
> 
> For instance,
> 
> commit 4d15c145a6234d999c0452eec0d275c1fbf0688c
> Author: Ben Widawsky <ben at bwidawsk.net>
> Date:   Thu Jul 4 11:02:06 2013 -0700
> 
>     drm/i915: Use eLLC/LLC by default when available
> 
> only extends the gtt to use eLLC/LLC cacheing and forgets to also update
> the ppgtt function pointer.
> 
> v2: Actually mention the bug being fixed (Kenneth)
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Ben Widawsky <ben at bwidawsk.net>
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

My bad. I've merged this to my temporary tree for when Daniel returns.

-- 
Ben Widawsky, Intel Open Source Technology Center



More information about the Intel-gfx mailing list