[Intel-gfx] [PATCH 2/2] drm/i915: Unpin stolen pages

Chris Wilson chris at chris-wilson.co.uk
Sat Jun 1 01:51:02 CEST 2013


On Fri, May 31, 2013 at 02:46:20PM -0700, Ben Widawsky wrote:
> The way the stolen handling works is we take a pin on the backing pages,
> but we never actually get a reference to the bo. On freeing objects
> allocated with stolen memory, the final unref will end up freeing the
> object with pinned pages count left. To enable an assertion to catch
> bugs in this code path, this patch cleans up that remaining pin.
> 
> Signed-off-by: Ben Widawsky <ben at bwidawsk.net>

That neatly explains the WARN. Not too happy about accumulating lots of
backing storage specific processing into free_object, but that can be
fixed up later (there is an obj->ops->release() pending).

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list