[Intel-gfx] [PATCH v2 1/7] drm: Add fb_helper->restore_fbdev_mode hook

Chris Wilson chris at chris-wilson.co.uk
Mon Jun 3 11:50:55 CEST 2013


On Fri, May 31, 2013 at 08:07:01PM +0300, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Drivers may need to turn off overlay planes, cursors, etc. when
> restoring the fbdev mode. So allow drivers to provide their own
> version of drm_fb_helper_restore_fbdev_mode() that can take care
> of such details.
> 
> Initially just plug in drm_fb_helper_restore_fbdev_mode for all
> drivers.

I really don't like the bool interface here, and it looks even more
confusing when passing through the hooks. Can we have this changed to be
a proper error code?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list