[Intel-gfx] [PATCH] drm/i915/sdvo: Use &intel_sdvo->ddc instead of intel_sdvo->i2c for DDC.

Daniel Vetter daniel at ffwll.ch
Tue Jun 4 17:48:28 CEST 2013


On Tue, Jun 04, 2013 at 04:35:32PM +0100, Chris Wilson wrote:
> On Tue, Jun 04, 2013 at 05:13:21PM +0200, Egbert Eich wrote:
> > In intel_sdvo_get_lvds_modes() the wrong i2c adapter record is used
> > for DDC. Thus the code will always have to rely on a LVDS panel
> > mode supplied by VBT.
> > In most cases this succeeds, so this didn't get detected for quite
> > a while.
> > 
> > Signed-off-by: Egbert Eich <eich at suse.de>
> 
> Good catch!
> Cc: stable at vger.kernel.org
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Yeah, nice catch. If my history digging is correct this has been broken in

commit f899fc64cda8569d0529452aafc0da31c042df2e
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Tue Jul 20 15:44:45 2010 -0700

    drm/i915: use GMBUS to manage i2c links

Patch merged with that note added, thanks.
-Daniel
> -Chris
> 
> -- 
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list