[Intel-gfx] [PATCH] drm/i915: implement HSW display sequences for package C8+

Daniel Vetter daniel at ffwll.ch
Wed Jun 5 20:04:48 CEST 2013


On Wed, Jun 5, 2013 at 7:20 PM, Paulo Zanoni <przanoni at gmail.com> wrote:
>>   So all together I vote for the generic interface to be called something
>>   like
>>
>>   intel_aux_display_runtime_forbid/allow
>
> I changed to intel_aux_display_shutdown_forbid/allow, because we
> forbid the shutdown, not the "runtime".

Just one quick comment: The idea was to be 100% consisten with the
runtime pm api (I've dropped the pm_ part unfortunately), which is:

extern void pm_runtime_allow(struct device *dev);
extern void pm_runtime_forbid(struct device *dev);

I think being consistent here is important in the light of us needing
runtime pm eventually anyway.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list