[Intel-gfx] [PATCH] drm/i915: distinguish between error messages in DIDL initialization

Paulo Zanoni przanoni at gmail.com
Wed Jun 5 21:06:36 CEST 2013


2013/6/5 Jani Nikula <jani.nikula at intel.com>:
> Two exactly same error messages on different error paths makes debugging
> difficult. Clarify the messages and distinguish them from each other.
>
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>

And we do print these messages on real-world machines.

Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com>

> ---
>  drivers/gpu/drm/i915/intel_opregion.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
> index 5c2d693..79be7cf 100644
> --- a/drivers/gpu/drm/i915/intel_opregion.c
> +++ b/drivers/gpu/drm/i915/intel_opregion.c
> @@ -312,7 +312,7 @@ static void intel_didl_outputs(struct drm_device *dev)
>         list_for_each_entry(acpi_cdev, &acpi_video_bus->children, node) {
>                 if (i >= 8) {
>                         dev_printk(KERN_ERR, &dev->pdev->dev,
> -                                   "More than 8 outputs detected\n");
> +                                  "More than 8 outputs detected via ACPI\n");
>                         return;
>                 }
>                 status =
> @@ -339,7 +339,7 @@ blind_set:
>                 int output_type = ACPI_OTHER_OUTPUT;
>                 if (i >= 8) {
>                         dev_printk(KERN_ERR, &dev->pdev->dev,
> -                                   "More than 8 outputs detected\n");
> +                                  "More than 8 outputs in connector list\n");
>                         return;
>                 }
>                 switch (connector->connector_type) {
> --
> 1.7.10.4
>



-- 
Paulo Zanoni



More information about the Intel-gfx mailing list