[Intel-gfx] [PATCH] drm/i915: hw state readout support for pixel_multiplier

Imre Deak imre.deak at intel.com
Thu Jun 6 13:50:15 CEST 2013


On Thu, 2013-06-06 at 12:45 +0200, Daniel Vetter wrote:
> Incomplete since ilk+ support needs proper pch dpll tracking first.
> SDVO get_config parts based on a patch from Jesse Barnes, but fixed up
> to actually work.
> 
> v2: Make sure that we call encoder->get_config _after_ we
> get_pipe_config to be consistent in both setup_hw_state and the
> modeset state checker. Otherwise the clever trick with handling the
> pixel mutliplier on i915G/GM where the encoder overrides the default
> value of 1 from the crtc get_pipe_config function doesn't work.
> Spotted by Imre Deak.
> 
> v3: Actually cross-check the pixel mutliplier (but not on pch split
> platforms for now). Now actually also tested on a i915G with a sdvo
> encoder plugged in.
> 
> Cc: <imre.deak at intel.com>
> Cc: Jesse Barnes <jbarnes at virtuousgeek.org>
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

Looks ok,
Reviewed-by: Imre Deak <imre.deak at intel.com>





More information about the Intel-gfx mailing list