[Intel-gfx] [PATCH] drm/i915: Make g4x_fixup_plane() operational again

[Daniel Vetter]

On Fri, Jun 7, 2013 at 11:41 AM,  <ville.syrjala at linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> Don't enable the cursor until g4x_fixup_plane() had a chance to do
> cast its magic spell.
>
> Egbert writes:
> "Today I had the chance to test this. First I tried
>  if I can still reproduce the blank with this patch
>  added when I disable my voodoo g4x_fixup_plane():
>  It turned out it still happens however very rarely
>  (like 1 out of 20 tries). When I reenabled my voodoo
>  the issue still occurred.
>  I had to switch two lines around, ie:
>
>          intel_enable_plane(dev_priv, plane, pipe);
>          if (IS_G4X(dev))
>                  g4x_fixup_plane(dev_priv, pipe);
>  +       intel_crtc_update_cursor(crtc, true);
>
>  to avoid the blank screen issue - which is it didn't
>  happen in ~75 tries."
>
> Acked-by: Egbert Eich <eich at suse.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Can you please add a comment in the code so that we don't do the same
mistake again?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch