[Intel-gfx] [PATCH 14/31] drm/i915: display pll hw state readout and checking

[Damien Lespiau]

On Wed, Jun 12, 2013 at 04:39:14PM +0300, Ville Syrjälä wrote:
> On Wed, Jun 12, 2013 at 02:31:23PM +0100, Damien Lespiau wrote:
> > On Wed, Jun 05, 2013 at 01:34:16PM +0200, Daniel Vetter wrote:
> > > @@ -8621,6 +8657,17 @@ static void intel_cpu_pll_init(struct drm_device *dev)
> > >  		intel_ddi_pll_init(dev);
> > >  }
> > >  
> > > +static bool ibx_pch_dpll_get_hw_state(struct drm_i915_private *dev_priv,
> > > +				      struct intel_shared_dpll *pll,
> > > +				      struct intel_dpll_hw_state *hw_state)
> > > +{
> > > +	uint32_t val;
> > > +
> > > +	val = I915_READ(PCH_DPLL(pll->id));
> > > +
> > > +	return val & DPLL_VCO_ENABLE;
> > > +}
> > > +
> > 
> > Don't we want !!(val & DPLL_VCO_ENABLE) here? we're comparing this to 0
> > and 1.
> 
> bool is always 0 or 1.

Oh, of course!

Reviewed-by: Damien Lespiau <damien.lespiau at intel.com>

then.

-- 
Damien