[Intel-gfx] [PATCH] drm/i915: tune down DIDL warning about too many outputs

[Paulo Zanoni]

2013/6/24 Daniel Vetter <daniel.vetter at ffwll.ch>:
> Nothing the user (nor we) really can do about this, but upsets a nice
> quiet boot.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=65988
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

What exactly is the impact of this problem? What happens when we
detect this? If we don't know which problems could happen when we
reach this condition, then I really don't think we should tune down
the message. If we know what is the impact of that message, then I
think we should add a nice comment explaining that, and only then
maybe tune down the message.

By the way, this message is seen on all Haswell machines I checked.


> ---
>  drivers/gpu/drm/i915/intel_opregion.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
> index 79be7cf..cfb8fb6 100644
> --- a/drivers/gpu/drm/i915/intel_opregion.c
> +++ b/drivers/gpu/drm/i915/intel_opregion.c
> @@ -311,8 +311,8 @@ static void intel_didl_outputs(struct drm_device *dev)
>
>         list_for_each_entry(acpi_cdev, &acpi_video_bus->children, node) {
>                 if (i >= 8) {
> -                       dev_printk(KERN_ERR, &dev->pdev->dev,
> -                                  "More than 8 outputs detected via ACPI\n");
> +                       dev_dbg(&dev->pdev->dev,
> +                               "More than 8 outputs detected via ACPI\n");
>                         return;
>                 }
>                 status =
> @@ -338,8 +338,8 @@ blind_set:
>         list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
>                 int output_type = ACPI_OTHER_OUTPUT;
>                 if (i >= 8) {
> -                       dev_printk(KERN_ERR, &dev->pdev->dev,
> -                                  "More than 8 outputs in connector list\n");
> +                       dev_dbg(&dev->pdev->dev,
> +                               "More than 8 outputs in connector list\n");
>                         return;
>                 }
>                 switch (connector->connector_type) {
> --
> 1.7.10.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Paulo Zanoni