[Intel-gfx] Tabs or spaces? (was: [I-G-T] tools/intel_reg_dumper: add hsw backlight registers)

Paul Menzel paulepanter at users.sourceforge.net
Mon Mar 4 12:09:01 CET 2013


Dear intel-gfx folks,


Am Montag, den 04.03.2013, 12:22 +0200 schrieb Jani Nikula:
> The more the merrier.
> 
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> ---
>  lib/intel_reg.h          |    5 +++++
>  tools/intel_reg_dumper.c |    5 +++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/lib/intel_reg.h b/lib/intel_reg.h
> index 99d97bb..db07064 100644
> --- a/lib/intel_reg.h
> +++ b/lib/intel_reg.h
> @@ -3465,6 +3465,11 @@ typedef enum {
>  #define  PWM_PIPE_B             (1 << 29)
>  #define BLC_PWM_CPU_CTL         0x48254
>  
> +#define BLC_PWM2_CTL		0x48350
> +#define BLC_PWM2_DATA		0x48354
> +#define BLC_MISC_CTL		0x48360
> +#define UTIL_PIN_CTL		0x48400
> +

looking at that change I noticed that tabs and spaces are mixed in that
file? What is preferred?

>  #define BLC_PWM_PCH_CTL1        0xc8250
>  #define  PWM_PCH_ENABLE         (1 << 31)
>  #define  PWM_POLARITY_ACTIVE_LOW        (1 << 29)

[…]


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20130304/9ff5601e/attachment.sig>


More information about the Intel-gfx mailing list