[Intel-gfx] [PATCH 16/28] drm/i915: add Punit read/write routines for VLV

[Jesse Barnes]

On Mon, 04 Mar 2013 10:43:03 +0200
Jani Nikula <jani.nikula at linux.intel.com> wrote:

> > +int valleyview_punit_read(struct drm_i915_private *dev_priv, u8 addr, u32 *val)
> > +{
> > +	u32 cmd, devfn, opcode, port, be, bar;
> > +
> > +	bar = 0;
> > +	be = 0xf;
> > +	port = IOSF_PORT_PUNIT;
> > +	opcode = PUNIT_OPCODE_REG_READ;
> > +	devfn = 16;
> > +
> > +	cmd = (devfn << IOSF_DEVFN_SHIFT) | (opcode << IOSF_OPCODE_SHIFT) |
> > +		(port << IOSF_PORT_SHIFT) | (be | IOSF_BYTE_ENABLES_SHIFT) |  
> 
> Should be << not | for IOSF_BYTE_ENABLES_SHIFT. Ditto in the write
> function below.
> 
> How about picking up a fixed and reworked version of this patch from the
> series I sent you? ;)

Yeah I suck.  I'll respin with your bits.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center