[Intel-gfx] [PATCH 09/20] drm/i915: add power context allocation and setup on VLV v2

[Jesse Barnes]

I'll have to check the docs again. I can comment it though if needed. 


Jesse Barnes, Intel Open Source Technology Center

-------- Original message --------
From: Chris Wilson <chris at chris-wilson.co.uk> 
Date: 03/11/2013  5:01 PM  (GMT-08:00) 
To: Daniel Vetter <daniel at ffwll.ch> 
Cc: Jesse Barnes <jbarnes at virtuousgeek.org>,	intel-gfx at lists.freedesktop.org 
Subject: Re: [Intel-gfx] [PATCH 09/20] drm/i915: add power context allocation
  and setup on VLV v2 
 
On Tue, Mar 12, 2013 at 12:40:30AM +0100, Daniel Vetter wrote:
> On Fri, Mar 08, 2013 at 10:45:52AM -0800, Jesse Barnes wrote:
> > The Gunit has a separate reg for this, so allocate some stolen space for
> > the power context and initialize the reg.
> 
> Is it a requirement to use stolen space? The reason we're allocating rings
> and all from stolen is just to test things a bit better and ensure we have
> a decent chance that stolen handling for fastboot works ... Some comment
> somewhere would be good to clarify this.

I'm in favour of making these small permanent allocations from stolen
whereever possible. But you are right to point out that we need to
clearly mark anthing that may require physically contiguous memory, just
in case.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20130312/68affe08/attachment.html>