[Intel-gfx] [PATCH 15/15] drm/i915: add missing space in error message

Ben Widawsky ben at bwidawsk.net
Fri Mar 15 22:10:20 CET 2013


On Wed, Mar 06, 2013 at 08:03:22PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni <paulo.r.zanoni at intel.com>
> 
> To avoid this:
> [  256.798060] [drm] capturing error event; look for more information
> in/sys/kernel/debug/dri/0/i915_error_state
> 
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
Reviewed-by: Ben Widawsky <ben at bwidawsk.net>


You may want to add to the commit message that this fixes the issue introduced below:
commit 2f86f1916504525a6fdd6b412374b4ebf1102cbe
Author: Ben Widawsky <ben at bwidawsk.net>
Date:   Mon Jan 28 15:32:15 2013 -0800

    drm/i915: Error state should print /sys/kernel/debug
        ...
    [danvet: split up long line.] <----- he did it
    Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

I personally still believe we shouldn't chop up strings like this.



> ---
>  drivers/gpu/drm/i915/i915_irq.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index aefc674..0abd8ec 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -1340,7 +1340,7 @@ static void i915_capture_error_state(struct drm_device *dev)
>  		return;
>  	}
>  
> -	DRM_INFO("capturing error event; look for more information in"
> +	DRM_INFO("capturing error event; look for more information in "
>  		 "/sys/kernel/debug/dri/%d/i915_error_state\n",
>  		 dev->primary->index);
>  
> -- 
> 1.7.10.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ben Widawsky, Intel Open Source Technology Center



More information about the Intel-gfx mailing list