[Intel-gfx] [RFC xf86-video-intel] sna: OpenBSD drm_i915_gem_execbuffer2 support

[Chris Wilson]

On Mon, Mar 25, 2013 at 11:08:09PM +0100, Mark Kettenis wrote:
> The OpenBSD version of struct drm_i915_execbuffer2 doesn't include the
> member for cliprect support.  Not entirely sure why.  Perhaps when
> Owain Ainsworth added GEM support, it was already obvious that
> cliprects were not going to be supported on new hardware and therefore
> not worth supporting.
> 
> Unfortunately the sna code explicitly initializes these members.
> Obviously we can't just add those members without breaking binary
> compatibility.  So the diff below takes an easy way out and adds an
> #infdef __OpenBSD__ around the initializations.  An alternative would
> be to use memset() to zero-initialize the entire struct and skip the
> initialization of members that are zero.  What would be preferred?

I would prefer a memset rather than adding ifdef.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre