[Intel-gfx] [PATCH 5/8] drm/i915: Move hotplug interrupt enable for i915/i965/valleyview into a separate function.

Jesse Barnes jbarnes at virtuousgeek.org
Tue Mar 26 21:04:23 CET 2013


On Thu, 10 Jan 2013 10:02:43 -0500
Egbert Eich <eich at suse.de> wrote:

> Signed-off-by: Egbert Eich <eich at suse.de>
> ---
>  drivers/gpu/drm/i915/i915_irq.c |  178 ++++++++++++++++++++++----------------
>  1 files changed, 103 insertions(+), 75 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 4e75df0..356472f 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -567,6 +567,32 @@ static void gen6_queue_rps_work(struct drm_i915_private *dev_priv,
>  	queue_work(dev_priv->wq, &dev_priv->rps.work);
>  }
>  
> +static void valleyview_enable_hotplug_irq(struct drm_device *dev)

Given how you use these later, _reset_hotplug_irq or _update_hotplug_irq
might be a better name, but that's no biggie.

Seems like a nice cleanup by itself even.

Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center



More information about the Intel-gfx mailing list