[Intel-gfx] [PATCH] drm/i915: clear crt hotplug compare voltage field before setting

Daniel Vetter daniel at ffwll.ch
Wed Mar 27 16:41:04 CET 2013


On Wed, Mar 27, 2013 at 05:02:43PM +0200, Ville Syrjälä wrote:
> On Wed, Mar 27, 2013 at 03:47:11PM +0100, Daniel Vetter wrote:
> > Noticed while reviewing the hotplug irq setup code. Just looks better.
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Queued for -next, thanks for the review.

> What about the activation period? Do we want to leave it alone on non
> g4x platforms, or should it also get cleared?

The activation period is just one bit, so setting it will dtrt. And there
are other values to tune the crt hotplug detection, so I've figured I'll
leave things as-is otherwise. The lack of proper masking just annoyed my
OCD a bit ;-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list