[Intel-gfx] [PATCH 1/7] drm/i915: simplify DP/DDI port width macros
daniel at ffwll.ch
Thu May 2 21:29:55 CEST 2013
On Thu, May 02, 2013 at 02:38:09PM -0300, Paulo Zanoni wrote:
> 2013/5/2 Daniel Vetter <daniel at ffwll.ch>:
> > On Thu, May 02, 2013 at 10:34:23AM -0300, Paulo Zanoni wrote:
> >> 2013/4/30 Daniel Vetter <daniel.vetter at ffwll.ch>:
> >> > If we ever leak a non-DP compliant port width through here, we have a
> >> > pretty serious issue. So just rip out all these WARNs - if we need
> >> > them it's probably better to have them at a central place where we
> >> > compute the dp lane count.
> >> >
> >> > Also use the new DDI width macro for FDI mode.
> >> >
> >> > Cc: Paulo Zanoni <paulo.r.zanoni at intel.com>
> >> > Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> >> Nice one.
> >> Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
> > Queued for -next, thanks for the review.
> And now that I've actually booted a Kernel with the patch I see that
> the chunk inside intel_ddi_enable_transcoder_func is wrong. We should
> assign to the "temp" variable, not "intel_dp->DP". This gives me a
> nice black screen on DP.
Oops. Ok, I've pushed an updated version, that one better?
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
More information about the Intel-gfx