[Intel-gfx] [PATCH 4/5] drm/i915: Apply OCD to data/link m/n register #defines

Daniel Vetter daniel at ffwll.ch
Fri May 3 11:15:08 CEST 2013

On Thu, May 02, 2013 at 05:36:33PM -0300, Paulo Zanoni wrote:
> Hi
> 2013/5/1 Daniel Vetter <daniel.vetter at ffwll.ch>:
> > - PCH_ prefix for pch registers on ibx/cpt/ppt.
> > - Drop the DP_ from the link defines, redundant.
> > - Drop the GMCH from the data defines and instead give the special g4x
> >   registers a consistent _G4X postfix.
> >
> > Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> Yay, the new naming is way better. Thanks!
> So since this is about OCD, I'll give my optional OCD bikesheds:
> - Now the register addresses are not aligned on i915_reg.h anymore. I
> suggest we align them again. We should also consider replacing all
> those white spaces with tabs.


> - We should have renamed the suspend/resume regfile registers too.
> They're getting confusing now.

Imo i915_ums.c is a dungeon and I don't want to change anything in there
if at all possible. Hence why I've kept the old names.

> - We go over 80 columns in some new cases now. Do we have a policy on
> when it's accepted on our driver?

I don't mind too much if something in the dungeons (i915_ums.c and
i915_dma.c overflows). Same for reg defines, since usually you don't
really read them that often. Real code in source files shouldn't overflow
for easier reading (with some exceptions for strings).

> - Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com> but I'd love to
> see my bikesheds on v2 :)

On it's way ;-)
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

More information about the Intel-gfx mailing list