[Intel-gfx] [PATCH] drm/i915: force full modeset if the connector is in DPMS OFF mode

Daniel Vetter daniel at ffwll.ch
Fri May 3 13:32:27 CEST 2013

On Fri, May 3, 2013 at 1:27 PM, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Fri, May 3, 2013 at 1:22 PM, Imre Deak <imre.deak at intel.com> wrote:
>> Currently the driver's assumed behavior for a modeset with an attached
>> FB is that the corresponding connector will be switched to DPMS ON mode
>> if it happened to be in DPMS OFF (or another power save mode). This
>> wasn't enforced though if only the FB changed, everything else (format,
>> connector etc.) remaining the same. In this case we only set the new FB
>> base and left the connector in the old power save mode.
>> Fix this by forcing a full modeset whenever there is an attached FB and
>> any affected connector is in a power save mode.
>> Signed-off-by: Imre Deak <imre.deak at intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=61642
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59834
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59339
> Safe for the first just a few wild guesses. Can you please spam
> bugzilla with this patch (there's tons more spurious kms_flip fail
> iirc, also a few of the kms_flip jitter reports should be fixed by
> now).

Also, and i-g-t to specifically exercise this would be nice ... Maybe
easiest on top of kms_flip, using dpms off, but then a set_base as an
implicit dpms on.
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

More information about the Intel-gfx mailing list