[Intel-gfx] [PATCH] drm/i915: get mode clock when reading the pipe config v2

Daniel Vetter daniel at ffwll.ch
Sat May 4 11:03:34 CEST 2013

On Sat, May 4, 2013 at 1:43 AM, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> On Fri,  3 May 2013 15:34:41 -0700
> Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
>> We need this for comparing modes between configuration changes.
>> v2: try harder to calulate non-simple pixel clocks (Daniel)
>>     call get_clock after getting the encoder config, needed for pixel multiply
>>     (Jesse)
> In reply to danvet's questions:
>   - I can move the pixel multiplier into get_config; I thought some of
>     our encoder regs had a bit that could be used
>   - if I do that, I don't need to call get_clock separately; it needs
>     the pixel multiplier to calculate m/n correctly, so that's why I
>     had to put it after the encoder get_config
> I added pipe config checks for the new mode flags, and I get warnings
> now, but I don't want to add one for the clock just yet.  Maybe after
> everything is in and working we can add one...

Yeah, if you have something known-broken in the pipe config check
it'll shadow all follow-up checks. So I think you could just smash the
clock comparison at the bottom with a big warning why it needs to be

Mode flags otoh I think we should be able to get right.
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

More information about the Intel-gfx mailing list