[Intel-gfx] [PATCH] drm/i915: add encoder get_config function

Daniel Vetter daniel at ffwll.ch
Mon May 6 18:22:09 CEST 2013


On Mon, May 6, 2013 at 6:14 PM, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
>                 if (encoder->get_hw_state(encoder, &pipe)) {
> -                       encoder->base.crtc =
> -                               dev_priv->pipe_to_crtc_mapping[pipe];
> +                       crtc = to_intel_crtc(dev_priv->pipe_to_crtc_mapping[pipe]);
> +                       if (encoder->get_config)
> +                               encoder->get_config(encoder, &crtc->config);
> +                       encoder->base.crtc = &crtc->base;
>                 } else {
>                         encoder->base.crtc = NULL;
>                 }

This needs to move into the pipe config read out support somehow,
otherwise we can't cross-check it. Note that I don't mind if you cheat
a bit on the cross-check support and e.g. restrict it to just ilk+ and
vlv. But I really think it should be there ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list