[Intel-gfx] [PATCH 2/2] drm/i915: add context into request struct

Ben Widawsky ben at bwidawsk.net
Tue May 7 07:12:29 CEST 2013


On Mon, May 06, 2013 at 12:28:18PM +0300, Mika Kuoppala wrote:
> Ben Widawsky <ben at bwidawsk.net> writes:
> 
> > On Thu, May 02, 2013 at 04:48:08PM +0300, Mika Kuoppala wrote:
> >> Storing context reference into request struct
> >> allows us to inspect context and its associated
> >> objects when requests are retired.
> >> 
> >> Both ppgtt and arb robustness work will need
> >> this.
> >> 
> >> Signed-off-by: Mika Kuoppala <mika.kuoppala at intel.com>
> >
> > Both 1&2 are:
> > Reviewed-by: Ben Widawsky <ben at bwidawsk.net>
> >
> > You should add your sob to 1, since you modified it (slightly), and
> > maybe run them both my Chris to make sure he approves as well.
> 
> I took 1/2 from:
> http://cgit.freedesktop.org/~bwidawsk/drm-intel/commit/?h=ppgtt-ctx&id=5e266650d53d42ebbc8c22f2846c8ed87d747b21
> 
> and i don't remember intentionally modifying it. Is there some merge fallout I
> missed? I couldn't spot any diff to original.
> 
> -Mika

Ah, I see. The original patch from Chris had all 4 args to add request.
My patch had already fixed it :-D

-- 
Ben Widawsky, Intel Open Source Technology Center



More information about the Intel-gfx mailing list