[Intel-gfx] [PATCH 1/7] drm: Add fb_helper->restore_fbdev_mode hook

[Laurent Pinchart]

Hi Ville,

Thank you for the patch.

On Wednesday 08 May 2013 12:55:16 ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Drivers may need to turn off overlay planes, cursors, etc. when
> restoring the fbdev mode. So allow drivers to provide their own
> version of drm_fb_helper_restore_fbdev_mode() that can take care
> of such details.
> 
> Initially just plug in drm_fb_helper_restore_fbdev_mode for all
> drivers.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>  drivers/gpu/drm/ast/ast_fb.c              | 1 +
>  drivers/gpu/drm/cirrus/cirrus_fbdev.c     | 1 +
>  drivers/gpu/drm/drm_fb_cma_helper.c       | 1 +
>  drivers/gpu/drm/drm_fb_helper.c           | 2 +-
>  drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 1 +
>  drivers/gpu/drm/gma500/framebuffer.c      | 1 +
>  drivers/gpu/drm/i915/intel_fb.c           | 1 +
>  drivers/gpu/drm/mgag200/mgag200_fb.c      | 1 +
>  drivers/gpu/drm/nouveau/nouveau_fbcon.c   | 1 +
>  drivers/gpu/drm/omapdrm/omap_fbdev.c      | 1 +
>  drivers/gpu/drm/qxl/qxl_fb.c              | 1 +
>  drivers/gpu/drm/radeon/radeon_fb.c        | 1 +
>  drivers/gpu/drm/udl/udl_fb.c              | 1 +
>  include/drm/drm_fb_helper.h               | 1 +
>  14 files changed, 14 insertions(+), 1 deletion(-)

[snip]

> diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
> index 8230b46..9f5b9be 100644
> --- a/include/drm/drm_fb_helper.h
> +++ b/include/drm/drm_fb_helper.h
> @@ -72,6 +72,7 @@ struct drm_fb_helper_funcs {
>  			       struct drm_fb_helper_crtc **crtcs,
>  			       struct drm_display_mode **modes,
>  			       bool *enabled, int width, int height);
> +	bool (*restore_fbdev_mode)(struct drm_fb_helper *fb_helper);

Could you please document this new function in the struct drm_fb_helper_funcs 
kerneldoc block ?

>  };
> 
>  struct drm_fb_helper_connector {
-- 
Regards,

Laurent Pinchart