[Intel-gfx] [RFC][PATCH 1/1] drm/i915: Rewrite ILK+ watermark handling

Jesse Barnes jbarnes at virtuousgeek.org
Thu May 9 21:09:30 CEST 2013

On Mon,  6 May 2013 16:45:52 +0300
ville.syrjala at linux.intel.com wrote:

> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Rewrite the ILK+ watermark code to allow:
> - updating the watermarks safely (to avoid underruns)
> - pre-computing watermarks (will help with atomic modest and pageflip)
> - enabling LP1+ watermarks for HSW multi-pipe scenarios

This looks like the right way to go long term.  But Paulo's patches for
HSW are fairly small and make things better immediately, so we should
probably get them in first.

This one needs to be split up somehow so we can review it better like
you mention in the TODO.

Another thing that I used when doing the WM code way back when was to
port it to userspace and run through various configs to make sure the
values were all sane.  Might be nice if we could do that easily
somehow, maybe with an #ifdef or putting all the wm stuff into a
separate file.

Jesse Barnes, Intel Open Source Technology Center

More information about the Intel-gfx mailing list