[Intel-gfx] [PATCH 2/4] drm/i915: use msecs_to_jiffies_timeout instead of open coding the same

Daniel Vetter daniel at ffwll.ch
Tue May 21 19:20:22 CEST 2013


We have another one of these in the wait_for register wait macro in
intel_drv.h Can you please amend your patch with that fixed up, too?

Thanks, Daniel

On Tue, May 21, 2013 at 7:03 PM, Imre Deak <imre.deak at intel.com> wrote:
> Signed-off-by: Imre Deak <imre.deak at intel.com>
> ---
>  drivers/gpu/drm/i915/intel_i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_i2c.c b/drivers/gpu/drm/i915/intel_i2c.c
> index 5d24503..98cd8535 100644
> --- a/drivers/gpu/drm/i915/intel_i2c.c
> +++ b/drivers/gpu/drm/i915/intel_i2c.c
> @@ -228,7 +228,7 @@ gmbus_wait_hw_status(struct drm_i915_private *dev_priv,
>          * need to wake up periodically and check that ourselves. */
>         I915_WRITE(GMBUS4 + reg_offset, gmbus4_irq_en);
>
> -       for (i = 0; i < msecs_to_jiffies(50) + 1; i++) {
> +       for (i = 0; i < msecs_to_jiffies_timeout(50); i++) {
>                 prepare_to_wait(&dev_priv->gmbus_wait_queue, &wait,
>                                 TASK_UNINTERRUPTIBLE);
>
> --
> 1.8.1.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list