[Intel-gfx] [PATCH 2/4] drm/i915: use msecs_to_jiffies_timeout instead of open coding the same

Daniel Vetter daniel at ffwll.ch
Tue May 21 20:20:41 CEST 2013

On Tue, May 21, 2013 at 8:00 PM, Imre Deak <imre.deak at intel.com> wrote:
> On Tue, 2013-05-21 at 19:20 +0200, Daniel Vetter wrote:
>> We have another one of these in the wait_for register wait macro in
>> intel_drv.h Can you please amend your patch with that fixed up, too?
> I noticed it, but didn't change it since we don't need there the +1
> adjustment to begin with. The time_after() check already makes sure we
> wait at least MS amount. So I think we should remove +1 from there..

Hm, right. Looks like the important part of

commit 1d5bfac96f1e1856fbdb3f06679691e5b9c2ba8f
Author: Daniel Vetter <daniel.vetter at ffwll.ch>
Date:   Thu Mar 28 00:03:25 2013 +0100

    drm/i915: fix up _wait_for macro

was to just recheck the condition after the timeout expired. I agree
that this is a separate patch.
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

More information about the Intel-gfx mailing list