[Intel-gfx] [PATCH 18/34] drm/i915: Drop dev from pte_encode
kenneth at whitecape.org
Sat May 25 22:14:43 CEST 2013
On 05/25/2013 12:26 PM, Ben Widawsky wrote:
> The original pte_encode function needed the dev argument so we could do
> platform specific handling via IS_GENX, etc. With the merging of a pte
> encoding function there should never been a need to quirk away gen
> specific details.
> The patch doesn't do much but makes the upcoming reworks in gtt/ppgtt/mm
> slightly (albeit, ever so) easier.
> CC: Kenneth Graunke <kenneth at whitecape.org>
> Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
Seems reasonable to me - just swap out pte_encode based on gen, rather
than looking at gen in the function.
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
More information about the Intel-gfx