[Intel-gfx] [PATCH -next] drm/i915: fix error return code in init_pipe_control()

Chris Wilson chris at chris-wilson.co.uk
Tue May 28 12:05:22 CEST 2013

On Tue, May 28, 2013 at 05:51:44PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
> Fix to return -ENOMEM in the kmap() error handling case
> instead of 0, as done elsewhere in this function.

kmap() can fail?

It is either translated to page_address() or kmap_high() (on x86),
neither of which may return NULL. However, only kmap_atomic() is
documented as being guaranteed to return a valid value. If we could
have a similar definitive statement for kmap(), we can then cleanup
quite a bit of redundant error handling.

Chris Wilson, Intel Open Source Technology Centre

More information about the Intel-gfx mailing list