[Intel-gfx] [PATCH 3/4] drm/i915: unpin pages at unbind

Chris Wilson chris at chris-wilson.co.uk
Fri May 31 20:46:16 CEST 2013


On Fri, May 31, 2013 at 11:28:47AM -0700, Ben Widawsky wrote:
> If we properly keep track of the pages_pin_count, then when we later add
> multiple address spaces, the put_pages doesn't need any special checks
> to be able to perform it's job.
> 
> CC: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Ben Widawsky <ben at bwidawsk.net>

Like. Since we don't expose the pages_pin_count to the user (unlike the
regular pin_count & pin_ioctl), then we should never have to perform a
cleanup in free_object(). Though as you have seen, we obviously need to
let this patch soak for a bit in case we missed some.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list