[Intel-gfx] [PATCH 2/4] [v2] drm/i915: Unbind the fb

Chris Wilson chris at chris-wilson.co.uk
Fri May 31 21:39:32 CEST 2013

On Fri, May 31, 2013 at 11:45:29AM -0700, Ben Widawsky wrote:
> This is the only place I could find where we don't already unbind the
> object before freeing it. This change will allow us to have a nice
> assertion on free about whether or not an object still has pinned pages.
> v2: Just use the i915 object instead of casting

The patch is flawed in that we try to do the unbind without mutex
protection. But it should already be unbound in free_object() anyway -
and doing so here is unlikely to fix the WARN_ON (presuming that is
what you are chasing).

Chris Wilson, Intel Open Source Technology Centre

More information about the Intel-gfx mailing list