[Intel-gfx] [PATCH] drm/i915/vlv: modeset_global_* for VLV v4

[Daniel Vetter]

On Fri, Nov 1, 2013 at 8:52 PM, Ville Syrjälä
<ville.syrjala at linux.intel.com> wrote:
>> +static void valleyview_modeset_global_pipes(struct drm_device *dev,
>> +                                         unsigned *prepare_pipes)
>> +{
>> +     struct drm_i915_private *dev_priv = dev->dev_private;
>> +     struct intel_crtc *intel_crtc;
>> +     int max_pixclk = intel_mode_max_pixclk(dev_priv);
>> +     int cur_cdclk = valleyview_cur_cdclk(dev_priv);
>> +
>> +     if (valleyview_calc_cdclk(dev_priv, max_pixclk) == cur_cdclk)
>> +             return;
>> +
>> +     list_for_each_entry(intel_crtc, &dev->mode_config.crtc_list,
>> +                         base.head)
>> +             if (intel_crtc->base.enabled)
>
> intel_crtc->active maybe? Although I guess they should be the same when
> this gets called.

A WARN_ON(intel_crtc->active) might be useful here to double-check
that the separet logic to frob prepare_pipes actually did it's job
correctly. It's always good to be paranoid when the logic needs to be
splattered over disparate pieces of code.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch