[Intel-gfx] [PATCH 1/4] tests: Fix "-thrashing" and "-thrash-inactive" distinction

oscar.mateo at intel.com oscar.mateo at intel.com
Mon Nov 4 17:30:46 CET 2013


From: Oscar Mateo <oscar.mateo at intel.com>

A typo in the relocation tests made both sub-tests perform the
same action: drop *all* caches.

Signed-off-by: Oscar Mateo <oscar.mateo at intel.com>
---
 tests/gem_persistent_relocs.c |    2 +-
 tests/gem_reloc_vs_gpu.c      |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/gem_persistent_relocs.c b/tests/gem_persistent_relocs.c
index 29b19ed..34d8492 100644
--- a/tests/gem_persistent_relocs.c
+++ b/tests/gem_persistent_relocs.c
@@ -289,7 +289,7 @@ static void do_forked_test(int fd, unsigned flags)
 	if (flags & (THRASH | THRASH_INACTIVE)) {
 		char fname[FILENAME_MAX];
 		int drop_caches_fd;
-		const char *data = THRASH_INACTIVE ? "0xf" : "0x7";
+		const char *data = (flags & THRASH_INACTIVE) ? "0x7" : "0xf";
 
 		snprintf(fname, FILENAME_MAX, "%s/%i/%s",
 			 "/sys/kernel/debug/dri", drm_get_card(),
diff --git a/tests/gem_reloc_vs_gpu.c b/tests/gem_reloc_vs_gpu.c
index ae7b446..bbfdc3a 100644
--- a/tests/gem_reloc_vs_gpu.c
+++ b/tests/gem_reloc_vs_gpu.c
@@ -284,7 +284,7 @@ static void do_forked_test(int fd, unsigned flags)
 	if (flags & (THRASH | THRASH_INACTIVE)) {
 		char fname[FILENAME_MAX];
 		int drop_caches_fd;
-		const char *data = THRASH_INACTIVE ? "0xf" : "0x7";
+		const char *data = (flags & THRASH_INACTIVE) ? "0x7" : "0xf";
 
 		snprintf(fname, FILENAME_MAX, "%s/%i/%s",
 			 "/sys/kernel/debug/dri", drm_get_card(),
-- 
1.7.9.5




More information about the Intel-gfx mailing list