[Intel-gfx] [PATCH] drm/i915: Demote drop_caches_set print

Chris Wilson chris at chris-wilson.co.uk
Wed Nov 6 10:19:42 CET 2013


On Wed, Nov 06, 2013 at 08:35:46AM +0100, Daniel Vetter wrote:
> On Tue, Nov 05, 2013 at 05:01:38PM -0800, Ben Widawsky wrote:
> > Many tests call this ad naseum now (in an infinite loop, very often).
> > It clutters the logs. Actually, I'd rather drop it completely...
> 
> Dropping it completely seems like the right solutions due to those "drop
> caches in an infinite loop" kind of tests.

By that argument we should remove all log messages. Why are we doing
this ad nausem? I thought the recent intention was to call it around
tests, in which case the debug log would be busy enough to hide this
noise. (Noise until it is vital to explain some behavioural artifact.)
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list