[Intel-gfx] [PATCH 2/2] drm/i915/vlv: For i915_cur_delayinfo, the max frequency reporting wrong value.

Daniel Vetter daniel at ffwll.ch
Thu Nov 7 17:55:58 CET 2013


On Thu, Nov 07, 2013 at 08:54:00AM -0800, Jesse Barnes wrote:
> On Thu,  7 Nov 2013 15:23:27 +0800
> Chon Ming Lee <chon.ming.lee at intel.com> wrote:
> 
> > The max frequency reporting is not correct.  But there is already an existing
> > valleyview_rps_max_freq and valleyview_rps_min_freq to get the
> > frequency.  Use that for i915_cur_delayinfo.
> > 
> > Signed-off-by: Chon Ming Lee <chon.ming.lee at intel.com>
> > ---
> >  drivers/gpu/drm/i915/i915_debugfs.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> > index cae3e9c..5254d95 100644
> > --- a/drivers/gpu/drm/i915/i915_debugfs.c
> > +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> > @@ -972,11 +972,11 @@ static int i915_cur_delayinfo(struct seq_file *m, void *unused)
> >  		seq_printf(m, "PUNIT_REG_GPU_FREQ_STS: 0x%08x\n", freq_sts);
> >  		seq_printf(m, "DDR freq: %d MHz\n", dev_priv->mem_freq);
> >  
> > -		val = vlv_punit_read(dev_priv, PUNIT_FUSE_BUS1);
> > +		val = valleyview_rps_max_freq(dev_priv);
> >  		seq_printf(m, "max GPU freq: %d MHz\n",
> >  			   vlv_gpu_freq(dev_priv->mem_freq, val));
> >  
> > -		val = vlv_punit_read(dev_priv, PUNIT_REG_GPU_LFM);
> > +		val = valleyview_rps_min_freq(dev_priv);
> >  		seq_printf(m, "min GPU freq: %d MHz\n",
> >  			   vlv_gpu_freq(dev_priv->mem_freq, val));
> >  
> 
> Ok yeah this is just ancient.  It never got fixed up when the other
> bits were added.
> 
> Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list