[Intel-gfx] [PATCH] drm/i915: restore the early forcewake cleanup

[Chris Wilson]

On Sat, Nov 16, 2013 at 04:00:09PM +0100, Daniel Vetter wrote:
> Some BIOS just leak the forcewak bits, which we clean up.
> Unfortunately this has been broken in
> 
> commit 521198a2e7095c8c7daa8d7d3a76a110c346be6f
> Author: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> Date:   Fri Aug 23 16:52:30 2013 +0300
> 
>     drm/i915: sanitize forcewake registers on reset
> 
> To make this work both for resets and for BIOS takeover just add the
> forcewake clearing call back to intel_uncore_early_sanitize.

The call to intel_uncore_forcewake_reset() is in
intel_uncore_sanitize(). Do you mind explaining the dependence that
causes us to require an ealry_sanitize?  There's no issue in doing so,
just the change log feels inaccurate.
 
> Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Reported-by: Jörg Otte <jrg.otte at gmail.com>
> Cc: Jörg Otte <jrg.otte at gmail.com>
> References: https://lkml.org/lkml/2013/11/16/40
> Cc: stable at vger.kernel.org (for 3.12 only)
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre