[Intel-gfx] [PATCH] drm/i915: remove intel_uncore_clear_errors

Paulo Zanoni przanoni at gmail.com
Mon Nov 18 17:48:08 CET 2013


2013/11/16 Daniel Vetter <daniel.vetter at ffwll.ch>:
> This was forgotten in
>
> commit 9d1cb9147dbe45f6e94dc796518ecf67cb64b359
> Author: Paulo Zanoni <paulo.r.zanoni at intel.com>
> Date:   Fri Nov 1 13:32:08 2013 -0200
>
>     drm/i915: avoid unclaimed registers when capturing the error state
>
> Cc: Paulo Zanoni <paulo.r.zanoni at intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com>

> ---
>  drivers/gpu/drm/i915/i915_drv.h     | 1 -
>  drivers/gpu/drm/i915/intel_uncore.c | 9 ---------
>  2 files changed, 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 8600c315b4c4..dce8c0882b29 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1907,7 +1907,6 @@ extern void intel_pm_init(struct drm_device *dev);
>  extern void intel_uncore_sanitize(struct drm_device *dev);
>  extern void intel_uncore_early_sanitize(struct drm_device *dev);
>  extern void intel_uncore_init(struct drm_device *dev);
> -extern void intel_uncore_clear_errors(struct drm_device *dev);
>  extern void intel_uncore_check_errors(struct drm_device *dev);
>  extern void intel_uncore_fini(struct drm_device *dev);
>
> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> index f9883ceff946..29532aeef294 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -790,15 +790,6 @@ int intel_gpu_reset(struct drm_device *dev)
>         }
>  }
>
> -void intel_uncore_clear_errors(struct drm_device *dev)
> -{
> -       struct drm_i915_private *dev_priv = dev->dev_private;
> -
> -       /* XXX needs spinlock around caller's grouping */
> -       if (HAS_FPGA_DBG_UNCLAIMED(dev))
> -               __raw_i915_write32(dev_priv, FPGA_DBG, FPGA_DBG_RM_NOCLAIM);
> -}
> -
>  void intel_uncore_check_errors(struct drm_device *dev)
>  {
>         struct drm_i915_private *dev_priv = dev->dev_private;
> --
> 1.8.4.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Paulo Zanoni



More information about the Intel-gfx mailing list