[Intel-gfx] [PATCH] Added a lower limit for the watermark setting

Thomas Richter thor at math.tu-berlin.de
Wed Nov 20 10:18:58 CET 2013


Am 19.11.2013 17:41, schrieb Daniel Vetter:
> On Tue, Nov 19, 2013 at 05:15:09PM +0100, Thomas Richter wrote:
>> Hi Daniel, dear intel experts,
>>
>> please find a patch attached that finally addresses the display
>> flicker on i830 chipsets. This
>> patch adds a lower watermark setting in intel_watermark_params{},
>> but keeps it zero for
>> all but the i830 chipsets. The necessary new defines are in i915_reg.h.
> I think we ned to split out the gen2/3 single/dual pipe watermark code a
> bit better from everything else. A bugfix for i830M shouldn't really
> affect snb ;-)

Actually, the fun part is that it does not because all the lower limits 
are zero for all other architectures.

>
> I've pushed out my current (and rather broken) wip branch with my idea on
> the take to
>
> http://cgit.freedesktop.org/~danvet/drm/log/?h=for-thomas

Could you please help me here how to apply it? I'm not very experienced 
with git, and it does not seem to fit to the sources of
intel_pm.c I have. Do I first need to instruct git to download another 
branch? I'm currently at drm-intel-nightly.

Thanks,
     Thomas






More information about the Intel-gfx mailing list