[Intel-gfx] [PATCH] drm/i915: Fix gen3 self-refresh watermarks

Daniel Vetter daniel at ffwll.ch
Wed Nov 20 15:53:19 CET 2013


On Wed, Nov 20, 2013 at 04:47:14PM +0200, Ville Syrjälä wrote:
> On Wed, Nov 20, 2013 at 03:02:10PM +0100, Daniel Vetter wrote:
> > This regression has been introduced in
> > 
> > commit 4fe8590a921d0b2e36e542dbfa89a8c5993f5a3f
> > Author: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > Date:   Wed Sep 4 18:25:22 2013 +0300
> > 
> >     drm/i915: Use adjusted_mode appropriately when computing watermarks
> > 
> > I guess we should renable the enabled local variable into something a
> > notch more descriptive, but that's something for -next.
> > 
> > The effect on my i945gme netbook is pretty severe amounts of underruns
> > - usually the very first pixel gets used for the entire screeen.
> > 
> > Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > Cc: Damien Lespiau <damien.lespiau at intel.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> 
> Dang. Copy paste fail on my part :( The fix looks good.
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Queued for -next, thanks for the review.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list