[Intel-gfx] [PATCH 01/10] drm/i915: Grab struct_mutex around all FBC updates

Daniel Vetter daniel at ffwll.ch
Thu Nov 21 09:22:43 CET 2013


On Wed, Nov 20, 2013 at 11:39 PM, Rodrigo Vivi <rodrigo.vivi at gmail.com> wrote:
> On Wed, Nov 06, 2013 at 11:02:16PM +0200, ville.syrjala at linux.intel.com wrote:
>> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>>
>> We need some protection for the FBC state, and since struct_mutex
>> is it currently in most places, make sure all FBC update/disable
>> calles are protected by it.
>
> Why don't you create a new mutex only for fbc update?

Yeah, if it's not core gem state please don't spread the usage of
dev->struct_mutex. Eventually we need to slash that one into pieces,
but until that happens making things worse doesn't help.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list