[Intel-gfx] [PATCH 10/10] drm/i915: Use plane_name() in gen7_enable_fbc()

[Ville Syrjälä]

On Thu, Nov 21, 2013 at 09:08:44AM +0100, Daniel Vetter wrote:
> On Wed, Nov 20, 2013 at 03:01:03PM -0800, Rodrigo Vivi wrote:
> > Reviewed-by: Rodrigo Vivi <rodrigo.vivi at gmail.com>
> > 
> > On Wed, Nov 06, 2013 at 11:02:25PM +0200, ville.syrjala at linux.intel.com wrote:
> > > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > > 
> > > All the other .enable_fbc() funcs use plane_name(). Make
> > > gen7_enable_fbc() do the same.
> > > 
> > > Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> I've picked up a few of the reviewed patches here. Overall we still have
> the issue that enabling the fbc tracking totally wreaks havoc with the
> blitter performance on gen6+ ... I still think the way to fix that is to
> do s/w based tracking and forgo all the neat hw support.

Maybe we can do both. The tracking code is not that intrusive IMO, so
giving the user a choice would make it easier to figure out if there
is a performance vs. power tradeoff between hardware and software
tracking.

-- 
Ville Syrjälä
Intel OTC