[Intel-gfx] [PATCH v2 6/8] drm/i915: don't do BDW/HSW specific powerdomains init on other platforms

[Paulo Zanoni]

2013/11/14 Imre Deak <imre.deak at intel.com>:
> Signed-off-by: Imre Deak <imre.deak at intel.com>

Since I assume all power wells will require some kind of
register-checking and hardware-touching at the init paths, shouldn't
we add power_well->init_hw() and call it once for each power well? The
problem with this series is that we're doing code changes for a case
we still didn't try to implement (multiple power wells), so sometimes
it gets hard to predict what exactly will be needed/used.

> ---
>  drivers/gpu/drm/i915/intel_pm.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index ee5aeb1..d5eacd8 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -5912,6 +5912,9 @@ void intel_power_domains_init_hw(struct drm_device *dev)
>         intel_display_set_init_power(dev, true);
>         intel_power_domains_resume(dev);
>
> +       if (!(IS_HASWELL(dev) || IS_BROADWELL(dev)))
> +               return;
> +
>         /* We're taking over the BIOS, so clear any requests made by it since
>          * the driver is in charge now. */
>         if (I915_READ(HSW_PWR_WELL_BIOS) & HSW_PWR_WELL_ENABLE_REQUEST)
> --
> 1.8.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Paulo Zanoni