[Intel-gfx] [PATCH 2/3] drm/i915/vlv: Valleyview support for forcewake Individual power wells.
Jesse Barnes
jbarnes at virtuousgeek.org
Mon Nov 25 17:36:59 CET 2013
On Sat, 23 Nov 2013 14:55:43 +0530
deepak.s at intel.com wrote:
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 9292c9e..04d46b2 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -4840,8 +4840,8 @@
> #define EDP_LINK_TRAIN_VOL_EMP_MASK_IVB (0x3f<<22)
>
> #define FORCEWAKE 0xA18C
> -#define FORCEWAKE_VLV 0x1300b0
> -#define FORCEWAKE_ACK_VLV 0x1300b4
> +#define FORCEWAKE_VLV 0x1300b0
> +#define FORCEWAKE_ACK_VLV 0x1300b4
> #define FORCEWAKE_MEDIA_VLV 0x1300b8
> #define FORCEWAKE_ACK_MEDIA_VLV 0x1300bc
> #define FORCEWAKE_ACK_HSW 0x130044
Another spurious hunk, but again maybe Daniel can drop it.
I'd have structured the force wake callbacks a little differently
(still used the vfunc then split the routines into separate _locked
variants for each of render and media), but that's just cosmetic. So:
Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
More information about the Intel-gfx
mailing list