[Intel-gfx] [PATCH 1/2] drm/i915/vlv: Make the vlv_dpio_read/vlv_dpio_write more PHY centric

[Daniel Vetter]

On Wed, Nov 27, 2013 at 12:18 AM, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> On Tue, 26 Nov 2013 15:10:22 -0800
> Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
>
>> On Mon, 11 Nov 2013 10:23:24 +0100
>> Daniel Vetter <daniel at ffwll.ch> wrote:
>>
>> > On Wed, Nov 06, 2013 at 12:51:05PM +0200, Ville Syrjälä wrote:
>> > > On Wed, Nov 06, 2013 at 02:36:35PM +0800, Chon Ming Lee wrote:
>> > > > vlv_dpio_read/write should be describe more in PHY centric instead of
>> > > > display controller centric.
>> > > > Create a enum dpio_channel for channel index and enum dpio_phy for PHY
>> > > > index.  This should better to gather for upcoming platform.
>> > > >
>> > > > v2: Rebase the code based on
>> > > > drm/i915/vlv: Fix typo in the DPIO register define.
>> > > >
>> > > > v3: Rename vlv_phy to dpio_phy_iosf_port and define additional macro
>> > > > DPIO_PHY, and remove unrelated change. (Ville)
>> > > >
>> > > > Suggested-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
>> > > > Signed-off-by: Chon Ming Lee <chon.ming.lee at intel.com>
>> > >
>> > > Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
>> >
>> > Queued for -next, thanks for the patch.
>>
>> Looks like this one gives me bogus DPIO values at least some of the
>> time.  Reverting to using 0x12 as the port ID seems to get me valid
>> values back...
>
> Ah looks like the init_dpio happens too late for the mode state
> readout.  I'll post a patch to move it up.

Isn't that just because your fb reconstruction patches moves it up by
a lot? If so can you please extract just that from your patches? I was
wondering whether we should do that due to the usual init ordering fun
anyway. I'd prefer to let that one soak a few days in dinq or so
before pulling in the hairy stuff.

Aside: The s/intelfbdev.ifb/intelfbdev->fb/ conversion would also be
neater split out.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch