[Intel-gfx] [PATCH 8/8] drm/i915: Enable FBC for all mobile gen2 and gen3 platforms

[Chris Wilson]

On Fri, Nov 29, 2013 at 03:10:17PM +0100, Daniel Vetter wrote:
> On Fri, Nov 29, 2013 at 01:56:19PM +0000, Chris Wilson wrote:
> > On Thu, Nov 28, 2013 at 05:30:02PM +0200, ville.syrjala at linux.intel.com wrote:
> > > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > > 
> > > All mobile gen2 and gen3 chipsets should have FBC1, and the code
> > > should now handle them all. So just set has_fbc=true for all such
> > > chipsets.
> > 
> > Just comment here that the default value for i915_enable_fbc is still
> > off for gen2, so for the user to actually enable FBC requires opting-in.
> 
> Can we please dare and just enable it? Imo going through all this trouble
> and not trying isn't really worth it ...

But as a separate patch with a host of tested-by and how much battery
life is improved... Ah, the joy of 10 year old batteries!
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre