[Intel-gfx] [PATCH 1/2] drm/i915: Hold pc8 lock around toggling pc8.gpu_idle

Chris Wilson chris at chris-wilson.co.uk
Thu Oct 10 22:34:41 CEST 2013

On Thu, Oct 10, 2013 at 05:04:27PM -0300, Paulo Zanoni wrote:
> 2013/10/10 Chris Wilson <chris at chris-wilson.co.uk>:
> > We need to hold the pc8 lock around toggling the value of gpu_idle.
> >
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Paulo Zanoni <paulo.r.zanoni at intel.com>
> Should we Cc:stable ?

Perhaps. Maybe this is a race condition that results in the enable_work
being kicked off...
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
> I wonder if we need to rename hsw_enable_package_c8 and
> __hsw_enable_package_c8 since we're spreading the usage of the "__"
> function. Suggestions/patches welcome :)

__hsw_enable_package_c8 follows the idiom of being the inner locked
variant that one should only call if they know they meet the
preconditions. It keeps the longer name as a deterrent against use.

Chris Wilson, Intel Open Source Technology Centre

More information about the Intel-gfx mailing list