[Intel-gfx] [PATCH] drm: add support for additional stereo 3D modes

[Damien Lespiau]

On Fri, Oct 11, 2013 at 02:12:14PM +0300, Ville Syrjälä wrote:
> On Thu, Oct 10, 2013 at 02:19:15PM +0100, Thomas Wood wrote:
> > +static int add_3d_struct_modes(struct drm_connector *connector, u16 structure,
> > +			       const u8 *video_db, u8 video_len, u8 video_index)
> > +{
> > +	struct drm_device *dev = connector->dev;
> > +	struct drm_display_mode *newmode;
> > +	int modes = 0;
> > +	u8 cea_mode;
> > +
> > +	if (video_db == NULL || video_index > video_len)
> > +		return 0;
> > +
> > +	/* CEA modes are numbered 1..127 */
> > +	cea_mode = (video_db[video_index] & 127) - 1;
> > +	if (cea_mode >= ARRAY_SIZE(edid_cea_modes))
> > +		return 0;
> > +
> > +	if (structure & 1) {
> 
> I'm also wondering if some displays might include some of the mandatory
> modes in 3D_Structure_ALL, and if so should we filter out the
> duplicates?

It can. Looks like drm_mode_connector_list_update() should be taking
care of the duplicated modes.

-- 
Damien